GFIR coefficient GUI & cleanup #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the file it would incorrectly say too many coefficients
rjonaitis
requested changes
Feb 1, 2024
src/lms7002m/LMS7002M.cpp
Outdated
| */ | ||
| int LMS7002M::GetGFIRCoefficients(TRXDir dir, uint8_t GFIR_index, int16_t* coef, uint8_t coefCount) | ||
| int LMS7002M::ReadGFIRCoefficients(TRXDir dir, uint8_t gfirIndex, float_type* coef, uint8_t coefCount) |
There was a problem hiding this comment.
what's the reasoning of function rename, Get vs Read?
There was a problem hiding this comment.
The other function taking in floating point numbers was named Write, so changed the naming to keep it consistent with that function.
Changing both functions now to be Set/Get instead to be consistent with the rest of LMS7002M code.
DominykasPetke
pushed a commit
to Matom-ai/LimeSuite
that referenced
this pull request
Mar 28, 2024
GFIR coefficient GUI & cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
constandconstexprFixed
Changed
lms7002_pnlMCU_BD_viewto C++'s IO librariesRemoved