Remove "All time" filter from admin timeline

On WhatDoTheyKnow this loads 17 million+ events, which attempts to use over 5GB of memory. In all but the smallest installs pagination will be required for this page to be performant, so this commit removes the filter entirely. Fixes #8369.
mysociety · Aug 29, 2024 · 0c9f549 · 0c9f549
1 parent 3d6bc4d
commit 0c9f549
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/app/helpers/admin_general_timeline_helper.rb b/app/helpers/admin_general_timeline_helper.rb
@@ -13,8 +13,7 @@ def time_filters
       'Day' => 1.day.ago,
       '2 days' => 2.days.ago,
       'Week' => 1.week.ago,
-      'Month' => 1.month.ago,
-      'All time' => Time.utc(1970, 1, 1)
+      'Month' => 1.month.ago
     }
   end
 

diff --git a/doc/CHANGES.md b/doc/CHANGES.md
@@ -2,6 +2,8 @@
 
 ## Highlighted Features
 
+* Remove "All time" filter from admin timeline due to performance issues (Gareth
+  Rees)
 * Add example logrotate configuration (Graeme Porteous)
 * Switch application server from Thin to Puma (Graeme Porteous)
 * Fix rendering invoices page when there are discounted Pro subscription (Graeme