[#1636] Show AlaveteliConfiguration in admin interface #8280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbp
reviewed
Jun 3, 2024
garethrees
force-pushed
the
1636-show-config-in-admin
branch
3 times, most recently
from
43f5a85
to
59518c9
Compare
garethrees
force-pushed
the
1636-show-config-in-admin
branch
from
59518c9
to
16fe5b1
Compare
garethrees
force-pushed
the
1636-show-config-in-admin
branch
from
16fe5b1
to
5cf52cf
Compare
Extract non-resourceful action to its own controller.
* Clean up the source code formatting * Add bootstrap table classes * Add a table-debug class for nicer font formatting
Makes it easier for less technical users to look up specific configuration values – or indeed, save technical users opening an ssh session. Fixes #1636
garethrees
force-pushed
the
1636-show-config-in-admin
branch
from
5cf52cf
to
c36b65e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #1636
What does this do?
Extract
AdminGeneralController#debugtoAdmin::DebugController#index, tidy up its view, and render a sanitised version ofAlaveteliConfigurationso that admins can view the configuration without a server ssh session.Why was this needed?
Helps less technical users and admins of Alavetelis hosted by mySociety.
Playing around with speaking at chatGPT after work because I was annoyed at having to ssh to figure out the
AlaveteliConfiguration.reply_very_late_after_daysvalue.Implementation notes
Weird issue with the routing – will try to resolve that before merge
Screenshots