Only link to non broken links on First Mark page #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
struan
force-pushed
the
142-link-q-across-sessions
branch
from
332489f
to
2f60c0b
Compare
struan
force-pushed
the
146-highlight-broken-links
branch
from
1fe3938
to
8f3b960
Compare
zarino
requested changes
Jun 14, 2024
There was a problem hiding this comment.
Code looks good, although I’ve not tried it end-to-end locally.
I wonder whether just printing out the broken URL will make it obvious enough that the link is actually broken? Should we include "[dead link]" after it?
I’d also be tempted to make dead links look more prominent too. The aim of #146 (although I realise I didn’t document this at the time) was to warn markers when a link has died, because that might mean the evidence that got a council a mark in the previous year no longer exists. Giving the link (or <span> if you still want it to just be plain text) a class="text-danger" attribute might help.
zarino
approved these changes
Jun 17, 2024
| @stringfilter | ||
| def check_if_broken(text, autoescape=True): | ||
| if check_if_url_bad(text): | ||
| return mark_safe(f'<span class="text-danger">{text}</a>') |
struan
force-pushed
the
142-link-q-across-sessions
branch
2 times, most recently
from
d14f9a6
to
434809f
Compare
struan
force-pushed
the
146-highlight-broken-links
branch
from
ae1df09
to
723ac35
Compare
This is currently quite unoptimised so might need improvement
|
Merges in 723ac35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the list of link status codes provided by CEUK to generate a list of bad links and then uses that to only turn good URLs into links in the previous responses part of the first mark page.
Fixes #146