Accessibility issues: WDTK #1146
Conversation
Just to note, and definitely not a review - I actually really like this - it has the secondary advantage of refreshing the design in a subtle way, whilst delivering known access benefits. Lovely stuff 👍 |
There was a problem hiding this comment.
🤌 I like it!
While the previous version wasn't an exact match, it was much closer to the mySociety brand colours. @zarino do you have an opinion on this?
|
I'm thinking we merge and deploy this when we start talking about our 20th anniversary. Am I correct in thinking there will be a banner added to WDTK for this? |
Sounds good.
Looks like its on its way https://github.com/mysociety/Design-Internal-tasks/issues/8#issuecomment-1410057767 |
I can't see that one, but I will link this to a couple of related tickets, so we've got them together: |
|
@gbp let's get this rebased & merged (finally! 😅) |
I have maintained the hue, increased the saturation a tiny bit and decreased the brightness. So, in essence, it's a darker, richer version of the previous one.
To improve contrast the color for the .form_item_note has been swapped from $color_mid_grey to $color_dark_grey.
garethrees
force-pushed
the
1138-accesibilty-issues
branch
from
bef0ec3
to
02b8cb1
Compare
This pull request contains some fixes for accessibility issues found in the WDTK theme.
$color_blue is now a darker, richer version that passes the contrast test:
Items on subnav pass contrast test
Secondary button a bit darker
Increase vertical padding for list items on help page
When creating a new request the footer notes now pass the contrast test
Fixes part of: #1138
The rest of the issues, will be fixed on the Alaveteli core.