-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1434] Added video section in Homepage #1541
Conversation
@garethrees One thing it would be good to have in mind. Do you want me to change the background colour of the video section, so it doesn't look like the "Recent Videos" section and the "Who can I request information from?" are from the same section. I couldn't find many examples on the current website to use, at the moment we have |
85a53b1
to
e661a94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
I have added only three videos
This is plenty.
My only concern is that some of the titles differ in length…
I think it looks great with the current videos and I'm not too concerned that we'll have titles that are wildly different in length.
In terms of styling I thought of these two options, let me know which one you prefer. Personally I find the card layout easier to scan
I agree, the card layout is lovely. Could we use YouTube embeds, though? Only having to add a new URL to the @research_videos
data structure would be much easier, rather than having to copy/paste the titles and create a thumbnail image every time we want to add a video. Keeping the cost of change low is very valuable.
I left a comment of for the donation button here
I'd like the donation button CTA as described, since that's one of the main reasons for adding these sections. I agree we should still have a "browse more" link that goes to our channel, but as the secondary CTA. I'm happy with the phrasing as I wrote it in the issue for now; this isn't worth lots of people's time this minute. We can tune it later on.
Is the position alright? Right below the how it works section. I thought this would be a better place because, in terms of info and content, we haven't reached the page section that has more content to read; therefore, I thought users would probably have the chance to see this content in comparison to leaving it at the end of the page.
I'm not sure what you mean by "we haven't reached the page section that has more content to read", but as with the research papers, ideally we'd position this below the "Who can I request information from?" / "What information has been requested?" section. The reason for this is that the research papers and videos are more incidental content, whereas the Alaveteli-generated lists are more directly about what to do on the site.
I can see that we don't have a great way of doing that at this point, so I've made a pull request – which will hopefully be merged by the time you read this! – that makes it easier to do this and keep the overrides a little simpler.
Should be an easy change:
- Create
lib/views/general/_frontpage_extra.html.erb
- Add
<%= render :partial => "frontpage_videos" %>
to that file
I'm glad you like it @garethrees
This is how the embeds would look like with the provided space: Without the YouTube API I don't think we can get the title. Instead of using the embed we could use the "ID" of the video to pull the thumbnail and the link. But the title would be needed to be added manually. This way we could keep the same card aesthetic without using the API. For the image Alt I would use the title. In terms of the donation would this work for you? Basically gives more priority the donation action than the "Browse more", but if you want to make the "Browse more" more obvious I could make it a secondary button, but I don't think is that advisable if the main purpose is for people to donate. |
This looks great – the less we have to do to add a video to the list the better.
Here's what I had in mind: I think it's important to indicate why we're asking for donations. The reason is that it supports us do the interesting things that we're showing immediately above. |
@garethrees I just pushed three commits that:
Let me know if there is anything else you'd like me to do =) |
Thanks for the feedback @garethrees I have rebased and fixed the indention on this PR. |
27f173c
to
9f6fd11
Compare
I'm getting having doubts about including the donation value on the button so will mull that over, but aside from that this is ready to go. We'll roll out in conjunction with #1146 and https://github.com/mysociety/Design-Internal-tasks/issues/8#issuecomment-1410057767. |
@@ -42,7 +42,7 @@ | |||
</div> | |||
|
|||
<div class="cta-button-wrapper"> | |||
<a class="button" href="https://www.mysociety.org/donate/?utm_medium=link&how-much=10">Donate £10</a> | |||
<a class="button" href="<%= donation_url('how-much' => 10, utm_content: 'homepage donate 10', utm_campaign: 'wdtk-homepage-videos') %>">Donate £10</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajparsons just want to check the utm tracking here.
Currently this generates the following URL (split for ease of reading):
https://www.mysociety.org/donate?
how-much=10&
utm_campaign=wdtk-homepage-videos&
utm_content=homepage+donate+10&
utm_medium=link&
utm_source=whatdotheyknow.com
I think I'll drop the £ value and change the button text to "Donate now", so that will end up as:
https://www.mysociety.org/donate?
how-much=10&
utm_campaign=wdtk-homepage-videos&
utm_content=homepage+donate+now&
utm_medium=link&
utm_source=whatdotheyknow.com
Is this what you'd expect? Easy to change if there's a better combo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good on campaigns settings, if dropping "donate £10" drop the how-much because our suggested one-off donation is now higher than that. If keeping it, also add an 'how-often=one-off' parameter.
See https://github.com/mysociety/orgsites/pull/1321 for more info on that.
Can be used in combination for a double button like this (example from the blog)
Added lazy load to images
Added fix that improves section limits
Just fix some spacing issues
We use 2-space
All related to FOI / Transparency
* More specific heading * Use “watch more” as we’ll be using “browse more” for a research papers section, so this adds some variety
`donation_url` sets some of the basic utm params. Also manually added some location-specific params.
We're experimenting with this a bit so easier to just point towards the correct page and use its defaults.
4a273b8
to
ca115c6
Compare
Fixes: #1434
A specific of #791.
@garethrees
Before merging a couple of things:
I thought this would be a better place because, in terms of info and content, we haven't reached the page section that has more content to read; therefore, I thought users would probably have the chance to see this content in comparison to leaving it at the end of the page.
Option 1
Option 1 mobile version
In this one we could replace the link for a button styling instead, if you are not too keen on the links with icons.
What I like about them, without looking at the label they already telling you what they are.
Option 2
Let me know your thought and I'll fix the PR