Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mirror GitHub workflow #1734

Merged
merged 5 commits into from
Jul 5, 2023
Merged

Add mirror GitHub workflow #1734

merged 5 commits into from
Jul 5, 2023

Conversation

gbp
Copy link
Member

@gbp gbp commented Jul 5, 2023

Sync changes made on GitHub back to the mySociety git repo.

gbp and others added 5 commits July 5, 2023 07:20
Sync changes made on GitHub back to the mySociety git repo.
Testing the GH workflow
@gbp gbp merged commit 71f1173 into master Jul 5, 2023
@dracos
Copy link
Member

dracos commented Jul 12, 2023

So every push is running CI and robocop workflows twice, once their own, and then again in order to decide whether to mirror. Given the mirror action is running the other two, can you stop their independent runs?

@gbp
Copy link
Member Author

gbp commented Jul 13, 2023

So every push is running CI and robocop workflows twice, once their own, and then again in order to decide whether to mirror. Given the mirror action is running the other two, can you stop their independent runs?

I don't believe that is the case. Unless I'm missing something, if you look at the Action tab in the Github UI, then it appears to be running only once.

@dracos
Copy link
Member

dracos commented Jul 13, 2023

To take the PR I just opened:

You can see they take different times, it's not like one is using the other one. The checks box on the #1747 shows 5 things being run. If you remove pull_request from robocop.yml and and push/pull_request from ci.yml, then the mirror runs will still run, I assume.

@gbp
Copy link
Member Author

gbp commented Jul 13, 2023

Ah right I see now. I'll get that the workflows updated. Thanks for flagging.

@dracos
Copy link
Member

dracos commented Jul 13, 2023

If you want a workflow to depend upon another workflow, there is the https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_run event, but that can only depend upon any of 1 or more workflows completing, not all of a group of workflows, for which I think you'd need to either combine them into separate jobs in one workflow, or only rely on the ones being pulled in.

@gbp gbp mentioned this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants