Make correspondence headers sticky. #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracos
force-pushed
the
sticky-correspondence-headers
branch
from
d63255c
to
a62a326
Compare
garethrees
approved these changes
Jul 14, 2023
dracos
force-pushed
the
sticky-correspondence-headers
branch
from
a62a326
to
f2ef6b9
Compare
lucascumsille
approved these changes
Jul 18, 2023
|
@dracos looks really great =) |
dracos
force-pushed
the
sticky-correspondence-headers
branch
from
f2ef6b9
to
f13f259
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
mysociety/alaveteli#4504
What does this do?
Makes the correspondence headers sticky so they're always visible as you scroll through the correspondence.
Why was this needed?
So that when you're reading some correspondence, you can always know if it's incoming or outgoing, who it's from and when it was sent.
Implementation notes
Wasn't sure if any bit of this would be in core rather than theme, but seemed to all fit nicely here anyway.
Screenshots
(before I fixed rounded corners)
Notes to reviewer
The rounded corners made it quite a bit more complicated because you don't want to see anything underneath the outside of the rounded corner. If you get rid of the rounded corners, most of it isn't needed.