Set Reply-To for data breach emails. #1768
Conversation
lib/data_breach.rb
Outdated
| @@ -53,6 +53,7 @@ def data_breach(report, logged_in_user) | |||
| from = MailHandler.address_from_name_and_email( | |||
| 'WhatDoTheyKnow.com data breach report', blackhole_email | |||
| ) | |||
| set_reply_to_headers(nil, 'Reply-To' => report.contact_email) | |||
There was a problem hiding this comment.
The contact_email field is optional, so we won't necessarily have an email address in report.contact_email.
We might also have a logged_in_user, so perhaps want to pass in the logged_in_user as the first argument, and then if there's an email address in contact_email, pass that in as the reply-to header?
Not sure exactly how the blackhole stuff works inside set_reply_to_headers, @gbp may be able to give more detailed guidance 🙂
There was a problem hiding this comment.
Whoops, swear I'd put an if in! Going mad.
The form asks for DPO email, not user's email, so presumed didn't want to involve the logged-in user at all in this, but, yes it certainly could do if desired.
I assumed the envelope was set to the From (which is blackhole in this case) by default in the absence of being set, so that wouldn't be changing anything.
There was a problem hiding this comment.
Yes on reflection I think you're right, best to leave the logged in user out of this.
dracos
force-pushed
the
1767-breach-reply-to
branch
from
4e86f74
to
7f15f93
Compare
|
Thanks both! |
Fixes #1767