[pro#622] Add Pro sign up ban check #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a YAML config file is present, check the payment card before the pro subscription is created. With the YAML: ```yaml - fingerprint: 123abc456DEF789gh address_zip: AB11AB - address_zip: CD11CD ``` This would add two bans. Prevent sign up if the payment card entered matches: 1. the fingerprint and postcode `AB1 1AB`, or 2. the postcode `cd11cd` For fingerprint, these come from the Stripe dashboard and are unique for a given card. See: https://stripe.com/docs/api/cards/object#card_object-fingerprint For postcodes/address zip we upcase and strip all white space from what is provided on the payment form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Connected to https://github.com/mysociety/alaveteli-professional/issues/622
What does this do?
Add Pro sign up ban check
Why was this needed?
When a YAML config file is present, check the payment card before the pro subscription is created.
Implementation notes
With the YAML:
This would add two bans. Prevent sign up if the payment card entered matches:
AB1 1AB, orcd11cdFor fingerprint, these come from the Stripe dashboard and are unique for a given card. See: https://stripe.com/docs/api/cards/object#card_object-fingerprint
For postcodes/address zip we upcase and strip all white space from what is provided on the payment form.