Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set custom mySociety Datasette URL #1798

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Set custom mySociety Datasette URL #1798

merged 1 commit into from
Jan 3, 2024

Conversation

garethrees
Copy link
Member

@garethrees garethrees commented Oct 19, 2023 •
edited
Loading

gbp
gbp approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@gbp gbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this but would why like this instead of a config/general.yml configuration variable which we would normally use?

@garethrees
Copy link
Member Author

I'm okay with this but would why like this instead of a config/general.yml configuration variable which we would normally use?

Added some notes in mysociety/alaveteli@a02cb12, but to expand on that, there's also a complexity cost for adding to general.yml. It already has 115 keys, which is a bit 😵‍💫. I expect we'll be the only people to use this config, but if there ends up being demand we can always upgrade it from a theme initialisation config to general.yml.

@gbp gbp merged commit 364f914 into master Jan 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbp gbp gbp approved these changes

Assignees
No one assigned
Labels
awaiting-deploy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garethrees @gbp