[#1822] Add template for immigration correspondence (ATAS)

[mdeuk]

Relevant issue(s)

Fixes #1822
Depends on mysociety/alaveteli#8121

What does this do?

This adds a new template Immigration correspondence (ATAS) which displays on requests made to body 93723 (FCDO).

Why was this needed?

There has been an uptick in requests to the FCDO which concern a specific immigration matter (ATAS), and this is not covered by the existing messages for this body.

Implementation notes

Nothing special to note.

Screenshots

Notes to reviewer

When testing this on a sandbox, I'm getting a weird glitch where it looks like every line is double spaced (e.g. \n\n). I think this is a problem with my environment, as it does the same with others (e.g. _subject_access_request), but it seemed worth noting anyway.

[mdeuk]

Sorry, looks like my base was out of date - despite git originally claiming otherwise. Hopefully I've not broken anything.

[gbp]

Screenshot:

Admin

Request after being hidden

Email

[gbp]

This is great. I have created mysociety/alaveteli#8121 so we can use conditionals to render different content for prominence reason.

Once that is merged, I'll commit/merge, and deploy:

diff --git a/lib/views/admin_request/hidden_user_explanation/_immigration_correspondence_atas.text.erb b/lib/views/admin_request/hidden_user_explanation/_immigration_correspondence_atas.text.erb
index a987341..2d5fb24 100644
--- a/lib/views/admin_request/hidden_user_explanation/_immigration_correspondence_atas.text.erb
+++ b/lib/views/admin_request/hidden_user_explanation/_immigration_correspondence_atas.text.erb
@@ -2,12 +2,13 @@
       'circumstances, via our service, and we have therefore hidden it ' \
       'from other users.') %>
 
-<%= _('👉 Getting the help you need' \
+<% if explanation %>
+<%= _('👉 Getting the help you need ' \
       '{{site_name}} is an independent website which helps people make ' \
       'Freedom of Information requests in public. We are not part of the ' \
       'Government.',
       site_name: site_name) %>
-      
+
 <%= _('You should contact the Foreign, Commonwealth, and Development Office '\
       '(FCDO) directly. They are the department responsible for the ATAS '\
       'scheme. ') %>
@@ -48,4 +49,5 @@ https://www.citizensadvice.org.uk/about-us/contact-us/contact-us/contact-us/
       'to misuse our service, we wanted to remind you of our house rules, '\
       'which are the conditions of use for our service.'\
       'You can find them at: {{help_house_rules}}',
-      help_house_rules: help_house_rules_url) %>
\ No newline at end of file
+      help_house_rules: help_house_rules_url) %>
+<% end %>

[WilliamWDTK]

There are a few textual changes I would make, referencing the parts marked in red in the image above (and text just by that section).

1. circumstances, via → circumstances via
2. needWhatDoTheyKnow: add line-break
3. Foreign, Commonwealth, and Development Office → at least Foreign, Commonwealth and Development Office, but ideally match official name and WDTK listing with Foreign, Commonwealth & Development Office
4. directly, at: atas@fcdo.gov.uk: might want to remove colon, and add a full stop at the end of the line, that's possibly personal preference.
5. MPs offices can ask the FCDO → MPs' offices can ask the FCDO
6. You will still be able to view it while logged in to the site. → You will still be able to view the request while logged into the site. (The mention of hiding was much earlier, so it's not clear what it is referring to, also in to → into.)

[gbp]

Thanks @WilliamWDTK I have made those changes (except for 6 as that requires a change in core Alaveteli codebase)

Updated screenshots:

[gbp]

Merged in 56d2d5b