Patch authority only response gatekeeper #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@garethrees this seems to work well. Can you see any issues which I might be missing with this approach? |
gbp
commented
Feb 29, 2024
Accept responses to authority only requests from extra addresses which authorities might use. For example no-reply addresses from case management systems which aren't changeable.
gbp
force-pushed
the
authority-only-response-gatekeeper
branch
from
b85d8f6
to
42c4416
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Patch authority only response gatekeeper
Why was this needed?
Accept responses to authority only requests from extra addresses which authorities might use. For example no-reply addresses from case management systems which aren't changeable.
Implementation notes
Made it so adding other addresses is trivial so volunteers can open PRs for other addresses like they do for
invalid_reply_addresses