Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Helen discovered
What does this do?
Improved contrast for the popup element so it passes contrast text
Why was this needed?
Implementation notes
Screenshots
Black version
Green version
I get why originally we are using the mySociety green. but I think the problem with that it rarely looks nice inmediately right next to the other colours, they tend to clash with each other. Assuming using green is important I added a gradient that makes it readable, but probably my least favourite option. I tried a darker version so we can continue using white font text, but it didn't look very nice next to the navbar.
WDTK Variation
I created a variation of WDTK primary colour, using the same HUE, unlike the green version I think this one looks more WDTK style.
Let me know if you have any preferences.
Notes to reviewer