feat: Use Devs Deps analyzer as base class for supported analyzers #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+50
to
+53
| private String depsDevBaseUrl = DEFAULT_BASE_URL; | ||
|
|
||
| public void setDepsDevBaseUrl(String depsDevBaseUrl) { | ||
| this.depsDevBaseUrl = depsDevBaseUrl; |
There was a problem hiding this comment.
@san-zrl Is there a reason for this change? Seems different to the other analysers.
...r/src/test/java/org/dependencytrack/repometaanalyzer/repositories/MavenMetaAnalyzerTest.java
Outdated
Show resolved
Hide resolved
n1ckl0sk0rtge
requested changes
Sep 26, 2024
...r/src/test/java/org/dependencytrack/repometaanalyzer/repositories/MavenMetaAnalyzerTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: san-zrl <san@zurich.ibm.com>
|
Changed MavenMetaAnalyzerTest to use Assertions.xxx in all test methods |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DepsDevMetaAnalyzeris now a base class of all analyzers whose purl type is supported by Deps Dev (e.g.MavenMetaAnalyzer). These 6 analyzers call super.analyze() in their analyze implementation and fetch the source repo from Dev Deps (if provided). All other meta attributes come via maven, npm, etc. This keeps the analyzer registration as is:supportedType()returns this purl type.supportedType()returns null to indicate this.Addressed Issue
Augments PR DependencyTrack#1457
Checklist