[BUG FIX] Config listener doesn't execute when querying result is config doesn't exist #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #712 +/- ##
==========================================
- Coverage 32.69% 32.67% -0.02%
==========================================
Files 45 45
Lines 3294 3296 +2
==========================================
Hits 1077 1077
- Misses 2136 2138 +2
Partials 81 81 ☔ View full report in Codecov by Sentry. |
|
这个pr有2部分：
这个pr先只修复listener执行逻辑，先合入一版本。 |
binbin0325
reviewed
Mar 11, 2024
| @@ -493,14 +493,17 @@ func (client *ConfigClient) refreshContentAndCheck(cacheData cacheData, notify b | |||
| cacheData.group, cacheData.tenant) | |||
| return | |||
| } | |||
| if configQueryResponse != nil && configQueryResponse.Response != nil && !configQueryResponse.IsSuccess() { | |||
| if configQueryResponse != nil && configQueryResponse.Response != nil && | |||
| !configQueryResponse.IsSuccess() && configQueryResponse.GetErrorCode() != 300 { | |||
There was a problem hiding this comment.
!=300 的状态码判断可以先去掉，只修复listen相关逻辑
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix up #711