Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG FIX] Config listener doesn't execute when querying result is config doesn't exist #712

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[BUG FIX] Config listener doesn't execute when querying result is config doesn't exist #712

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37002fe
fix up
robynron Jan 12, 2024
a714309
tiny fix
robynron Feb 28, 2024
7eaa226
tiny fix
robynron Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions clients/config_client/config_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,14 +493,17 @@ func (client *ConfigClient) refreshContentAndCheck(cacheData cacheData, notify b
cacheData.group, cacheData.tenant)
return
}
if configQueryResponse != nil && configQueryResponse.Response != nil && !configQueryResponse.IsSuccess() {
if configQueryResponse != nil && configQueryResponse.Response != nil &&
!configQueryResponse.IsSuccess() && configQueryResponse.GetErrorCode() != 300 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!=300 的状态码判断可以先去掉，只修复listen相关逻辑

logger.Errorf("refresh cached config from server error:%v, dataId=%s, group=%s", configQueryResponse.GetMessage(),
cacheData.dataId, cacheData.group)
return
}
cacheData.content = configQueryResponse.Content
cacheData.contentType = configQueryResponse.ContentType
cacheData.encryptedDataKey = configQueryResponse.EncryptedDataKey
if len(strings.TrimSpace(configQueryResponse.ContentType)) > 0 {
cacheData.contentType = configQueryResponse.ContentType
}
if notify {
logger.Infof("[config_rpc_client] [data-received] dataId=%s, group=%s, tenant=%s, md5=%s, content=%s, type=%s",
cacheData.dataId, cacheData.group, cacheData.tenant, cacheData.md5,
Expand Down
Loading