Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Australia - Fix Friday before AFL Grand Final for 2024 #721

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Australia - Fix Friday before AFL Grand Final for 2024 #721

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
669d84e
Cleanup code
tinohager Nov 15, 2024
0740521
Add missing date for 2024 Friday before AFL Grand Final
tinohager Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/Nager.Date/HolidayProviders/AustraliaHolidayProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,6 @@ protected override IEnumerable<HolidaySpecification> GetHolidaySpecifications(in
var firstMondayInOctober = DateHelper.FindDay(year, Month.October, DayOfWeek.Monday, Occurrence.First);
var firstTuesdayInNovember = DateHelper.FindDay(year, Month.November, DayOfWeek.Tuesday, Occurrence.First);

//var newYearsDay = new DateTime(year, 1, 1).Shift(saturday => saturday.AddDays(2), sunday => sunday.AddDays(1));
//var christmasDay = new DateTime(year, 12, 25).Shift(saturday => saturday.AddDays(2), sunday => sunday.AddDays(2));
//var boxingDay = new DateTime(year, 12, 26).Shift(saturday => saturday.AddDays(2), sunday => sunday.AddDays(2));
//var australiaDay = new DateTime(year, 1, 26).Shift(saturday => saturday.AddDays(2), sunday => sunday.AddDays(1));

var weekendObservedRuleSet = new ObservedRuleSet
{
Saturday = date => date.AddDays(2), Sunday = date => date.AddDays(1),
Expand Down Expand Up @@ -332,6 +327,7 @@ private HolidaySpecification[] MonarchBirthday(int year)
case 2019:
case 2021:
case 2023:
case 2024:
{
var lastFridayInSeptember = DateHelper.FindLastDay(year, Month.September, DayOfWeek.Friday);

Expand Down