Maintenance (#820)

- Updates Abort-Mission (lib and plugin) version to 5.0.0
- Updates Docker tests to use JDK 17
- Removes unused dependency metadata
- Stops using the buildDir Gradle reference
- Stops using a deprecated method in a Docker test
- Updates readme

{patch}

Signed-off-by: Esta Nagy <nagyesta@gmail.com>

README.md

@@ -19,8 +19,7 @@ alternative for the cases when using a real Key Vault is not practical or imposs
 
 ## Recommended use
 
-### Warning!
-
+> [!WARNING]  
 > Lowkey Vault is NOT intended as an [Azure Key Vault](https://azure.microsoft.com/en-us/services/key-vault/) replacement. Please do not attempt using it instead of the real service in production as it is not using any security measures to keep your secrets safe.
 
 ### Valid use-cases
@@ -53,7 +52,8 @@ I have an app using Azure Key Vault and:
 
 ### Docker
 
-Note: a complex example is available [here](https://github.com/nagyesta/lowkey-vault-example-docker)
+> [!NOTE]  
+> A complex example is available [here](https://github.com/nagyesta/lowkey-vault-example-docker)
 
 1. Pull the most recent version from ```nagyesta/lowkey-vault```
    - You can find a list of all the available tags [here](https://hub.docker.com/r/nagyesta/lowkey-vault/tags)

build.gradle

@@ -79,10 +79,10 @@ configure(subprojects.findAll({
     jacocoTestReport {
         reports {
             xml.required.set(true)
-            xml.outputLocation.set(file("$buildDir/reports/jacoco/report.xml"))
+            xml.outputLocation.set(layout.buildDirectory.file("reports/jacoco/report.xml").get().getAsFile())
             csv.required.set(false)
             html.required.set(true)
-            html.outputLocation.set(file("$buildDir/reports/jacoco/html"))
+            html.outputLocation.set(layout.buildDirectory.dir("reports/jacoco/html").get().getAsFile())
         }
     }
 
@@ -94,8 +94,8 @@ configure(subprojects.findAll({
     }
 
     jacocoTestCoverageVerification {
-        inputs.file(file("${buildDir}/reports/jacoco/report.xml") as String)
-        outputs.file(file("${buildDir}/reports/jacoco/jacocoTestCoverageVerification") as String)
+        inputs.file(layout.buildDirectory.file("reports/jacoco/report.xml").get().getAsFile())
+        outputs.file(layout.buildDirectory.file("reports/jacoco/jacocoTestCoverageVerification").get().getAsFile())
 
         violationRules {
             rule {
@@ -134,13 +134,13 @@ configure(subprojects.findAll({
             }
         }
         doLast {
-            file("${buildDir}/reports/jacoco/jacocoTestCoverageVerification").write("Passed")
+            layout.buildDirectory.file("reports/jacoco/jacocoTestCoverageVerification").get().getAsFile().write("Passed")
         }
     }
     jar.dependsOn check
 
     tasks.withType(Checkstyle).configureEach {
-        configProperties = [base_dir: rootDir.toString(), cache_file: file("${buildDir}/checkstyle/cacheFile")]
+        configProperties = [base_dir: rootDir.toString(), cache_file: layout.buildDirectory.file("checkstyle/cacheFile").get().getAsFile()]
         reports {
             xml.required.set(false)
             html.required.set(true)

gradle/libs.versions.toml

@@ -17,14 +17,14 @@ testcontainers = "1.19.3"
 cucumber = "7.15.0"
 mockitoCore = "5.8.0"
 jupiter = "5.10.1"
-abortMission = "4.2.122"
+abortMission = "5.0.0"
 checkstyle = "10.12.2"
 jacoco = "0.8.10"
 jacksonBom = { strictly = "2.16.1" }
 jackson = { strictly = "2.16.1" }
 openApiUi = "2.3.0"
 
-abortMissionPlugin = "4.1.46"
+abortMissionPlugin = "5.0.0"
 dockerPlugin = "0.35.0"
 indexScanPlugin = "2.6.2"
 lombokPlugin = "8.4"

lowkey-vault-app/build.gradle

@@ -38,7 +38,7 @@ java {
 }
 
 test {
-    outputs.file(file("$buildDir/reports/abort-mission/abort-mission-report.json"))
+    outputs.file(layout.buildDirectory.file("reports/abort-mission/abort-mission-report.json").get().getAsFile())
     useJUnitPlatform()
     systemProperty("junit.jupiter.extensions.autodetection.enabled", true)
     systemProperty("junit.jupiter.execution.parallel.enabled", true)

lowkey-vault-docker/build.gradle

@@ -33,19 +33,19 @@ dependencies {
 }
 
 java {
-    sourceCompatibility = JavaVersion.VERSION_11
+    sourceCompatibility = JavaVersion.VERSION_17
     toolchain {
-        languageVersion = JavaLanguageVersion.of(11)
+        languageVersion = JavaLanguageVersion.of(17)
     }
     withJavadocJar()
     withSourcesJar()
 }
 
 tasks.register('copyAppJar', Copy.class) {
     inputs.file(rootProject.project(":lowkey-vault-app").tasks.named("bootJar").get().outputs.files.singleFile)
-    outputs.file("${buildDir}/app/lowkey-vault.jar")
+    outputs.file(layout.buildDirectory.file("app/lowkey-vault.jar").get().getAsFile())
     from rootProject.project(":lowkey-vault-app").tasks.named("bootJar").get().outputs.files.singleFile
-    into file("${buildDir}/app/")
+    into layout.buildDirectory.dir("app/").get().getAsFile()
     rename {
         'lowkey-vault.jar'
     }
@@ -57,11 +57,11 @@ docker {
     name "lowkey-vault:${rootProject.version}"
     tag 'dockerNagyesta', "nagyesta/lowkey-vault:${rootProject.version}"
     dockerfile file('src/docker/Dockerfile')
-    files file("${buildDir}/app/lowkey-vault.jar")
+    files layout.buildDirectory.file("app/lowkey-vault.jar").get().getAsFile()
     pull true
     noCache true
 }
-tasks.dockerPrepare.inputs.file("${buildDir}/app/lowkey-vault.jar")
+tasks.dockerPrepare.inputs.file(layout.buildDirectory.file("app/lowkey-vault.jar").get().getAsFile())
 tasks.dockerPrepare.dependsOn copyAppJar
 clean.mustRunAfter dockerClean
 
@@ -80,12 +80,12 @@ tasks.dockerRun.dependsOn tasks.docker
 
 test {
     inputs.file(rootProject.project(":lowkey-vault-app").tasks.named("bootJar").get().outputs.files.singleFile)
-    outputs.file(file("$buildDir/reports/abort-mission/abort-mission-report.json"))
-    outputs.dir(file("$buildDir/reports/cucumber"))
+    outputs.file(layout.buildDirectory.file("reports/abort-mission/abort-mission-report.json").get().getAsFile())
+    outputs.dir(layout.buildDirectory.dir("reports/cucumber").get().getAsFile())
     systemProperty("cucumber.execution.parallel.enabled", System.getProperty("test.parallel"))
     systemProperty("cucumber.filter.tags", "not @ignore")
     useTestNG {
-        systemProperty("abort-mission.report.directory", file("${buildDir}/reports/abort-mission/"))
+        systemProperty("abort-mission.report.directory", layout.buildDirectory.dir("reports/abort-mission/").get().getAsFile())
         systemProperty("abort-mission.force.abort.evaluators", rootProject.ext.dockerAbortGroups)
         systemProperty("abort-mission.suppress.abort.evaluators", rootProject.ext.dockerSuppressGroups)
     }

lowkey-vault-docker/src/test/java/com/github/nagyesta/lowkeyvault/steps/CertificateStepDefAssertion.java

@@ -271,7 +271,8 @@ public byte[] getThumbprint(final X509Certificate certificate) throws CryptoExce
             messageDigest.update(certificate.getEncoded());
             return messageDigest.digest();
         } catch (final Exception e) {
-            throw new CryptoException("Failed to calculate thumbprint for certificate: " + certificate.getSubjectDN().getName(), e);
+            throw new CryptoException("Failed to calculate thumbprint for certificate: "
+                    + certificate.getSubjectX500Principal().getName(), e);
         }
     }