Make WWW-Authenticate header resource parameter configurable #1150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1149
Description
Adds an additional
LOWKEY_AUTH_RESOURCE
argument which is used in the WWW-Authenticate header for the resource parameter. Defaults to"localhost"
.Entry point
Probably with the #1149 issue.
Checklists
{major}
,{minor}
or{patch}
Notes
Same notes as the linked issue:
@Value
arguments (Null? Empty String?)@Value
in the auth filter constructor is a "good thing", but took inspiration from theVaultImporterProperties
class and ... it does seem the shortest route to a possible fixOne last thought:
disableChallengeResourceVerification
is in use, I guess theresource
parameter doesn't matter. If it's not, it's running a custom hostname, and presumably that would be a subdomain ofvault.azure.net
so ... maybe it could just be straight up hard-coded in a similar way to the Basis-Theory emulator? 🤷🏻♂️