Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of the WWW-Authenticate headers #1151

Merged
merged 2 commits into from
Sep 21, 2024

Conversation

nagyesta
Copy link
Owner

Issue: #1149

Description

  • Adds new properties to allow customization of the WWW-Authenticate header
  • Changes the CommonAuthHeaderFilter to support custom resource URIs
  • Uses default value of the LOWKEY_AUTH_RESOURCE property to keep existing logic in place
  • Changes token endpoint to return WWW-Authenticate headers as well
  • Allows configuration of the realm used by the token endpoint using LOWKEY_TOKEN_REALM
  • Updates tests
  • Updates documentation

Entry point

Checklists

  • I have rebased my branch
  • My commit message is meaningful
  • The commit messages use semantic versioning: {major}, {minor} or {patch}
  • The changes are focusing on the issue at hand
  • I have maintained or increased test coverage

Notes

Craig Roberts and others added 2 commits September 21, 2024 19:57
Signed-off-by: Craig Roberts <github@craig.craig0990.co.uk>
… with custom hostname

- Uses default value of the LOWKEY_AUTH_RESOURCE property to keep existing logic in place
- Changes token endpoint to return WWW-Authenticate headers as well
- Allows configuration of the realm used by the token endpoint using LOWKEY_TOKEN_REALM
- Updates tests

Resolves #1149
{minor}

Signed-off-by: Esta Nagy <nagyesta@gmail.com>
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.96%. Comparing base (6c5c13e) to head (02f44d3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1151   +/-   ##
=========================================
  Coverage     98.96%   98.96%           
- Complexity     2019     2024    +5     
=========================================
  Files           239      239           
  Lines          4926     4936   +10     
  Branches        193      194    +1     
=========================================
+ Hits           4875     4885   +10     
  Misses           38       38           
  Partials         13       13           
Flag Coverage Δ
app 99.36% <100.00%> (+<0.01%) ⬆️
client 94.00% <ø> (ø)
testcontainers 97.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nagyesta nagyesta merged commit f38f7e0 into main Sep 21, 2024
14 checks passed
@nagyesta nagyesta deleted the feature/1149-www-auth-headers branch September 21, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant