Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the fallback version suffix to +git.{sha} #31

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

Pesa
Copy link
Member

@Pesa Pesa commented Apr 25, 2024

Seems to be more commonly used than the current -commit-{sha}. But mainly this is just to keep the logic and versioning scheme consistent with other projects.

Also cleanup/simplify the version handling code and fix the list of dependencies in the CI scripts (python3-minimal is not enough).

Seems to be more commonly used than the current `-commit-{sha}`.
Also cleanup/simplify the version handling code and fix the list
of dependencies in the CI scripts.
@pulsejet
Copy link
Collaborator

Makes sense, thanks

@pulsejet pulsejet merged commit 1bf5c25 into named-data:master Apr 27, 2024
27 of 28 checks passed
@Pesa Pesa deleted the version-from-git branch April 27, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants