Remove frontiers table from ledger #4425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsiganos
reviewed
Feb 12, 2024
dsiganos
previously approved these changes
Feb 12, 2024
pwojcikdev
reviewed
Feb 15, 2024
pwojcikdev
reviewed
Feb 15, 2024
clemahieu
force-pushed
the
remove_frontiers_table
branch
from
9f10d06 to
9f2d728
Compare
clemahieu
force-pushed
the
remove_frontiers_table
branch
from
9f2d728 to
b4b5d09
Compare
|
Split this commit. This is the second part which includes database changes which we can merge later in the release cycle since it upgrades the database. The first part is in this commit #4460 |
clemahieu
force-pushed
the
remove_frontiers_table
branch
2 times, most recently
from
5b53647 to
15f600e
Compare
clemahieu
force-pushed
the
remove_frontiers_table
branch
from
15f600e to
278d6de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frontiers table is redundant and only used for legacy block processing. It tracks a mapping of head block hash to account number. This information can already be obtained by the previous block's sideband information, which contains the account number, and the account_info which contains the head block.
This rewrites the ledger checks in terms of the already existing information and removes updates to the frontiers table and associated tests. This also does a ledger upgrade which drops the frontiers table.