Use unique ptrs for all node components #4814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
force-pushed
the
use-unique-ptrs
branch
from
f4e940f to
7cdc57c
Compare
Test Results for Commit 7cdc57cPull Request 4814: Results Test Case Results
Last updated: 2024-12-30 19:22:49 UTC |
clemahieu
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stores all node components as unique ptrs which means they do not need full class definitions included in node header.
One cleanup that is still left to do is removing unnecessary includes from
node.hppheader. I attempted doing it in this PR but it was messy as a lot of components implicly rely on these includes; it's a larger refactoring.