Remove idle check from WP requests (#333)

nanoframework · Nov 30, 2021 · 95b80db · 95b80db
1 parent b0509e7
commit 95b80db
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 21 deletions.
diff --git a/nanoFramework.Tools.DebugLibrary.Shared/WireProtocol/Controller.cs b/nanoFramework.Tools.DebugLibrary.Shared/WireProtocol/Controller.cs
@@ -17,6 +17,14 @@ public class Controller : IControllerLocal
         private readonly int nextEndpointId;
         private readonly object incrementLock = new object();
 
+        /// <summary>
+        /// Threshold for considering the communication channel idle.
+        /// </summary>
+        /// <remarks>
+        /// The default idle time is 100ms.
+        /// </remarks>
+        public TimeSpan IdleThreshold { get; set; } = TimeSpan.FromMilliseconds(100);
+
         public IControllerHostLocal App { get; internal set; }
 
         public CLRCapabilities Capabilities { get; set; }
@@ -59,7 +67,7 @@ internal set
 
         public bool IsIdle()
         {
-            return (DateTime.UtcNow - _lastActivity).TotalMilliseconds > 50;
+            return (DateTime.UtcNow - _lastActivity).TotalMilliseconds > IdleThreshold.TotalMilliseconds;
         }
 
         public bool Send(MessageRaw raw)

diff --git a/nanoFramework.Tools.DebugLibrary.Shared/WireProtocol/WireProtocolRequest.cs b/nanoFramework.Tools.DebugLibrary.Shared/WireProtocol/WireProtocolRequest.cs
@@ -40,25 +40,6 @@ public WireProtocolRequest(OutgoingMessage outgoingMessage, int millisecondsTime
 
         internal bool PerformRequest(IController controller)
         {
-            const int sleepTimeMs = 10;
-            int attemptsCount = 10000 / sleepTimeMs;
-
-            // wait for controller to be idle
-            while (
-                !controller.IsIdle() &&
-                attemptsCount > 0)
-            {
-                Thread.Sleep(10);
-
-                attemptsCount--;
-            }
-
-            if(attemptsCount == 0)
-            {
-                // timeout waiting for idle controller
-                return false;
-            }
-
             Debug.WriteLine($"Performing request");
 
             DebuggerEventSource.Log.WireProtocolTxHeader(OutgoingMessage.Base.Header.CrcHeader
@@ -93,7 +74,6 @@ internal void RequestAborted()
                 OutgoingMessage.Base.Header.Seq,
                 OutgoingMessage.Base.Header.SeqReply,
                 RequestTimestamp);
-
         }
     }
 }