Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter class names should follow PascalCase instead of camelCase. #1635

Open
abhisrkckl opened this issue Aug 31, 2023 · 0 comments
Open

Parameter class names should follow PascalCase instead of camelCase. #1635

abhisrkckl opened this issue Aug 31, 2023 · 0 comments

Comments

@abhisrkckl
Copy link
Contributor

According to PEP 8, python classes are supposed to be named in PascalCase. This is the convention we follow everywhere in PINT except for Parameter classes, which leads to weird-looking class names like maskParameter and floatParameter. I think we should change these to PascalCase.

This will be a breaking API change, but Parameter classes are not really meant for the end user, so it should be fine?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abhisrkckl