Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion over handing of pnadd #1844

Open
dlakaplan opened this issue Sep 25, 2024 · 0 comments
Open

Confusion over handing of pnadd #1844

dlakaplan opened this issue Sep 25, 2024 · 0 comments

Comments

@dlakaplan
Copy link
Contributor

From what I can see, the way PINT handles -pnadd flags is:

  • construct a phase array from the sum of -phase and -pnadd flags
  • use that to populate the delta_pulse_number column
  • add those values on a toa-by-toa basis to the residuals

However, we got a comment that this is not how TEMPO2 does it. The comment there is that:

the pulse number “-pn” is reset to 0 where “-pnadd” is provided. The “-pnadd” value gets added to the “-pn” values of all subsequent ToAs.
PINT does neither of these things. It does not set -pn to 0, and it only adds -pnadd to each TOA separately.

Can somebody clarify how TEMPO2 handles these things? Is the PINT behavior actually intentionally different? I don't see tests for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant