Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a release action #497

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

melissawm
Copy link
Member

References and relevant issues

Addresses #490
Closes #486
Depends on napari/napari.github.io#417

Description

This action will build and deploy docs for a new release, copying the built docs artifacts to both the dev and the {version} folders in napari.github.io. It will also update the stable symlink to point to the new version folder.

This action will be triggered by a new release tag pushed to the repo or by manually trigerring the action with an input specifying the new version (any input different from the default dev will trigger the action.)

This action will build and deploy docs for a new release, copying
the built docs artifacts to both the dev and the {version} folders
in napari.github.io. It will also update the stable symlink to point
to the new version folder.

This action will be triggered by a new release tag pushed to the repo or
by manually trigerring the action with an input specifying the new version
(any input different from the default dev will trigger the action.)
@melissawm
Copy link
Member Author

I am creating this as a draft, since there will need to be at least some docs written around this strategy, and I was hoping to get some feedback before we commit to it.

.github/workflows/build_and_deploy.yml Outdated Show resolved Hide resolved
.github/workflows/build_and_deploy.yml Show resolved Hide resolved
external_repository: napari/napari.github.io
publish_dir: ./html
publish_branch: gh-pages
destination_dir: ${{ github.event.inputs.target_directory || github.event.release.tag_name }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could potentially create a wrong folder if the wrong version string is passed as input to the action.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to validate this entry :(

@psobolewskiPhD
Copy link
Member

I think this makes sense to me and would make releases easier--they're happening more frequently now, so it's worth it!

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 22, 2024
@melissawm melissawm force-pushed the release-action branch 2 times, most recently from dfb87f5 to 1ee986a Compare October 22, 2024 17:58
@melissawm melissawm marked this pull request as ready for review October 22, 2024 18:01
@melissawm
Copy link
Member Author

This is ready for another look, thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation task
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

Deploy action should deploy to both the release folder *and* dev on release
2 participants