Add info on testing QWidget visibility
#370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
lucyleeow
commented
Mar 9, 2024
|
|
||
| ## Running tests | ||
|
|
||
| To run our test suite locally, run `pytest` on the command line. If, for some reason | ||
| you don't already have the test requirements in your environment, run `python -m pip install -e .[testing]`. | ||
|
|
||
| There are a very small number of tests (<5) that require showing GUI elements, (such |
|
Looks good to me! 👍 |
| Pytest fixtures to aid testings live in: | ||
|
|
||
| * [`napari/conftest.py`](https://github.com/napari/napari/blob/main/napari/conftest.py) | ||
| * [`napari_builtins/_tests/conftest.py`](https://github.com/napari/napari/blob/main/napari_builtins/_tests/conftest.py) |
There was a problem hiding this comment.
I would put this separately and mention that it's fixtures for the builtins plugin
There was a problem hiding this comment.
Will do, but I think we need a section describing what the builtins plugin is. see: #321
| * [`napari_builtins/_tests/conftest.py`](https://github.com/napari/napari/blob/main/napari_builtins/_tests/conftest.py) | ||
| * [`napari/utils/_testsupport.py`](https://github.com/napari/napari/blob/main/napari/utils/_testsupport.py) | ||
|
|
||
| These fixtures from are available globally to all of `napari`. |
There was a problem hiding this comment.
I don't think the napari_builtins ones are available to napari tests (or vice versa) as they are in separate directories
|
Thanks for review @DragaDoncila, changes made! |
DragaDoncila
approved these changes
Mar 13, 2024
Czaki
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Follow on from napari/napari#6722
Description
QWidgetvisibility. I was not sure if this info was relevant more generally beyondQWidgets (e.g., forQWindow?). Happy to change._testsupport.pyis exported, see: https://github.com/napari/napari/blob/27851ee92913e02b16d05b0aba19b126fa1e29e3/pyproject.toml#L191C24-L191C36