Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy docs on manual trigger #462

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Conversation

jni
Copy link
Member

@jni jni commented Jul 22, 2024

It turns out that we are building docs but not deploying docs when we merge
napari/napari PRs, and also on manually-triggered workflows. Only merges to
main on the napari/docs repo get deployed.

This PR also adds workflow_dispatch to the conditions in which built docs are
deployed. (This is also the mechanism by which merges in napari/napari trigger
docs building in the this repo.)

I have also added actionlint from napari/napari#7049 so that I can play around
with the long conditional and line continuations without screwing everything
up. 😂
Edit: Actionlint was failing on unrelated parts of the action, so I have decided to split it into a separate PR.

@github-actions github-actions bot added the task label Jul 22, 2024
@jni jni added this to the 0.5.1 milestone Jul 22, 2024
@jni jni added the maintenance CI, dependencies, and other maintenance label Jul 22, 2024
@jni jni merged commit dc51261 into napari:main Jul 22, 2024
9 checks passed
@jni jni deleted the deploy-docs-on-manual-trigger branch July 22, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance CI, dependencies, and other maintenance task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants