-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reconsider returning a list of strings in writer plugins #228
Comments
totally agree. Returning the list of strings is awkward. We don't really do anything with the info and it would be more natural for people to rely on exceptions. os.stat as a check is an idea, but it has some cost and doesn't really do anything that a properly handled write API doesn't do. |
this would be a schema version bump? |
hmm... a good question. it doesn't change the schema does it, but it does change the api expected of the plugin. This was that kinda amorphous "napari plugin API" version that we've discussed before. Did we decide just to use |
I think we should use it for both. Here it might mean the implementation of Implementing the change might look like:
|
complete side note here... @nclack, maybe we should reconsider the "merit" of requiring them to return a list of strings. Do we do anything with it? could we instead check
os.stat
of the path to check if anything happened? or, is there good reason to require them to return a list of paths (e.g. perhaps with remote paths where we can't evaluate before/after)Originally posted by @tlambert03 in napari/cookiecutter-napari-plugin#130 (comment)
The text was updated successfully, but these errors were encountered: