Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tomlpp #294

Merged
merged 5 commits into from
Jun 8, 2023
Merged

remove tomlpp #294

merged 5 commits into from
Jun 8, 2023

Conversation

tlambert03
Copy link
Collaborator

closes #291 by using tomli instead

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #294 (c10230e) into main (e4aefb2) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #294   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         2785      2787    +2     
=========================================
+ Hits          2785      2787    +2     
Impacted Files Coverage Δ
src/npe2/_inspection/_setuputils.py 100.00% <ø> (ø)
src/npe2/manifest/_bases.py 100.00% <100.00%> (ø)

@nclack nclack merged commit 8fb9e3e into napari:main Jun 8, 2023
Czaki added a commit to napari/docs that referenced this pull request Jun 8, 2023
# Description

The napari/npe2#294 breaks the docs building as
we use the most recent npe2 repository, not matching npe2 version. In
this PR I add `git checkout call` to have the npe2 repository cloned in
a version matching the installed npe2 version.

## Type of change
- [x] Fixes or improves existing content


---------

Co-authored-by: Ashley Anderson <aganders3@gmail.com>
@tlambert03 tlambert03 added the build build and dependencies label Jul 16, 2023
jni added a commit to regro-cf-autotick-bot/npe2-feedstock that referenced this pull request Jul 24, 2023
jni added a commit to regro-cf-autotick-bot/npe2-feedstock that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytomlpp dependecny make it hard to install on aarch64 (e.g docker for mac).
3 participants