Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font_size field to ThemeContribution class #300

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

dalthviz
Copy link
Member

Add font_size field to theme contribution definition following changes at napari/napari#5607

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #300 (daa64b4) into main (a63112c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #300   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         2811      2813    +2     
=========================================
+ Hits          2811      2813    +2     
Files Changed Coverage Δ
src/npe2/manifest/contributions/_themes.py 100.00% <100.00%> (ø)

@GenevieveBuckley
Copy link
Contributor

Now that napari/napari#5607 is merged, one of the next steps listed is to move this PR out of draft status (see comment). What needs to happen to facilitate that?

@dalthviz
Copy link
Member Author

dalthviz commented Aug 1, 2023

I think the missing thing was to merge napari/napari#5607. Will update this to get the latest changes on main and mark it as ready for review if checks pass 👍

@dalthviz dalthviz marked this pull request as ready for review August 1, 2023 16:08
Copy link
Collaborator

@nclack nclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks

@GenevieveBuckley
Copy link
Contributor

Thanks @dalthviz 🎉

@GenevieveBuckley GenevieveBuckley merged commit d01b554 into napari:main Aug 2, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants