DOC Add doc in CommandRegistry about when it is updated
#316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the CI failures are related to this doc change. |
DragaDoncila
approved these changes
Oct 11, 2023
|
Looks like our codecov token might have expired, or something: [2023-10-10T02:14:55.728Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:]
(https://codecov.io/) Error: There was an error fetching the storage URL during POST: 400 - [ErrorDetail(string='This
repository has been deactivated. To resume uploading to it, please activate the repository in the codecov UI:
https://app.codecov.io/github/napari/npe2/settings', code='invalid')]
@Czaki do you know what I'd need to do to fix this? |
Co-authored-by: Draga Doncila Pop <17995243+DragaDoncila@users.noreply.github.com>
Co-authored-by: Draga Doncila Pop <17995243+DragaDoncila@users.noreply.github.com>
|
Thanks changes made! |
Codecov Report
@@ Coverage Diff @@
## main #316 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 37 37
Lines 2814 2814
=======================================
Hits 2807 2807
Misses 7 7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some info about when
CommandRegistryis updated. Uses info learned when debugging #314Happy to change wording or move to a better place.