Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move coverage upload to separate step #323

Merged
merged 20 commits into from
Nov 21, 2023
Merged

Move coverage upload to separate step #323

merged 20 commits into from
Nov 21, 2023

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Oct 29, 2023

This PR move coverage to separate steep nad add coverage summary information in action summary

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #323 (39eef8d) into main (9d29e4d) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main      #323      +/-   ##
===========================================
+ Coverage   99.75%   100.00%   +0.24%     
===========================================
  Files          38        37       -1     
  Lines        2814      2774      -40     
===========================================
- Hits         2807      2774      -33     
+ Misses          7         0       -7     
Files Coverage Δ
src/npe2/_inspection/_fetch.py 100.00% <100.00%> (+3.57%) ⬆️

@Czaki
Copy link
Collaborator Author

Czaki commented Oct 30, 2023

Ok. Windows tests are broken from a long time, but this reveals a much deeper problem as inspecting is using imports and imported packages are present in sys.modules after virtualenv removal.

@Czaki
Copy link
Collaborator Author

Czaki commented Oct 31, 2023

Codecov will be fixed once the new test plugin is released.

cc @DragaDoncila

yield None


def test_entry_points_importable(plugin_env):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give me a bit more context around this removal? Was it always xfail-ing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no CI job with TEST_PACKAGE_NAME defined so it land in xfail branch.

@jni jni changed the title Move coverage upload to separate steep Move coverage upload to separate step Oct 31, 2023
tests/test_fetch.py Outdated Show resolved Hide resolved
@DragaDoncila
Copy link
Contributor

DragaDoncila commented Nov 3, 2023

Hmm smh now this test is failing because afaict the npe2 adapter doesn't convert npe1 themes? I don't really understand what this test is testing. I get that this is testing that fetching the manifest of an npe1 plugin works as expected, and includes its conversion to npe2, but it's odd because both the sample dict of dicts error and the theme error don't occur when launching the plugin in napari with the npe2 adapter enabled - which means it should be converting fine, no?

tests/test_fetch.py Outdated Show resolved Hide resolved
@DragaDoncila
Copy link
Contributor

@Czaki I ended up just removing the theme from the npe1 plugin as well

@Czaki
Copy link
Collaborator Author

Czaki commented Nov 3, 2023

So it looks ready for review :)

Copy link
Collaborator

@nclack nclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks!

@nclack nclack merged commit a5af6e8 into napari:main Nov 21, 2023
32 checks passed
@Czaki Czaki deleted the fix_tests branch November 21, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants