-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move coverage upload to separate step #323
Conversation
Codecov Report
@@ Coverage Diff @@
## main #323 +/- ##
===========================================
+ Coverage 99.75% 100.00% +0.24%
===========================================
Files 38 37 -1
Lines 2814 2774 -40
===========================================
- Hits 2807 2774 -33
+ Misses 7 0 -7
|
Ok. Windows tests are broken from a long time, but this reveals a much deeper problem as inspecting is using imports and imported packages are present in |
Codecov will be fixed once the new test plugin is released. |
yield None | ||
|
||
|
||
def test_entry_points_importable(plugin_env): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you give me a bit more context around this removal? Was it always xfail-ing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no CI job with TEST_PACKAGE_NAME
defined so it land in xfail branch.
This reverts commit 4033086.
Hmm smh now this test is failing because afaict the npe2 adapter doesn't convert npe1 themes? |
@Czaki I ended up just removing the theme from the npe1 plugin as well |
So it looks ready for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks!
This PR move coverage to separate steep nad add coverage summary information in action summary