Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registration to plugin categories #355

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

jni
Copy link
Member

@jni jni commented Jun 21, 2024

Closes #317

@jni
Copy link
Member Author

jni commented Sep 8, 2024

@DragaDoncila? 🙏

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2b5f7b2) to head (5430fd0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #355   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         2758      2759    +1     
=========================================
+ Hits          2758      2759    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I think Registration is definitely fair to include, especially as we now have a menu for it yay! I don't think this is sufficiently controversial to warrant a waiting period, so I'm going to merge.

@DragaDoncila DragaDoncila merged commit 3af9d1c into napari:main Sep 11, 2024
32 checks passed
@jni jni deleted the category-registration branch September 11, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: add "registration" to allowed categories
2 participants