Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On disable, dont try to pop a key that doesn't exist #356

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

psobolewskiPhD
Copy link
Member

Closes napari/napari#7135

This is a naive fix. If the key doesn't exist when disabling, just return None.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (eeeeacc) to head (73995ca).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #356   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         2758      2758           
=========================================
  Hits          2758      2758           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DragaDoncila
Copy link
Contributor

DragaDoncila commented Jul 29, 2024

This might fix the issue but I'm concerned that the early return in that function didn't save us - I think that check only works across a single session, but it's still not clear to me what's going on exactly. I was also able to reproduce this back to 0.4.18 which seems unbelievable?? So I'm looking at this a bit closer to figure out what's going on

@DragaDoncila
Copy link
Contributor

Ahh yess, I see what's going on. It's my own code 🤣 And that's why it's broken back to 0.4.18, because it's in the new npe2 release...

Copy link
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this addresses the issue. Let's merge and release npe2 asap

@DragaDoncila DragaDoncila merged commit c564891 into napari:main Jul 29, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling a plugin in the manager prevents napari from re-luanching
2 participants