Skip to content

Commit

Permalink
Fix base64 usage in osx-64, upload to CI artifacts only (#149)
Browse files Browse the repository at this point in the history
* use shell redirect?

* Remove WebFreak001/deploy-nightl, use CI artifacts instead
  • Loading branch information
jaimergp authored Jun 6, 2024
1 parent 08348f0 commit 0bb254d
Showing 1 changed file with 5 additions and 16 deletions.
21 changes: 5 additions & 16 deletions .github/workflows/make_bundle_conda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -339,8 +339,8 @@ jobs:
KEYCHAIN_PATH="$RUNNER_TEMP/installer-signing.keychain-db"
# import certificate and provisioning profile from secrets
echo -n "${{ secrets.APPLE_INSTALLER_CERTIFICATE_BASE64 }}" | /usr/bin/base64 --decode --output $INSTALLER_CERTIFICATE_PATH
echo -n "${{ secrets.APPLE_APPLICATION_CERTIFICATE_BASE64 }}" | /usr/bin/base64 --decode --output $APPLICATION_CERTIFICATE_PATH
echo -n "${{ secrets.APPLE_INSTALLER_CERTIFICATE_BASE64 }}" | /usr/bin/base64 --decode > $INSTALLER_CERTIFICATE_PATH
echo -n "${{ secrets.APPLE_APPLICATION_CERTIFICATE_BASE64 }}" | /usr/bin/base64 --decode > $APPLICATION_CERTIFICATE_PATH
# create temporary keychain
security create-keychain -p "${{ secrets.TEMP_KEYCHAIN_PASSWORD }}" $KEYCHAIN_PATH
Expand Down Expand Up @@ -485,11 +485,12 @@ jobs:
- name: Upload Artifact
uses: actions/upload-artifact@v4
# CI artifact uploads only on manual runs
if: inputs.event_name == 'workflow_dispatch' || github.event_name == 'workflow_dispatch'
# CI artifact uploads only on manual and scheduled runs
if: inputs.event_name == 'workflow_dispatch' || github.event_name == 'workflow_dispatch' || inputs.event_name == 'schedule'
with:
name: napari-${{ env.version }}-${{ runner.os }}-${{ env.arch-suffix }}.${{ env.extension }}
path: ${{ github.workspace }}/napari-packaging/_work/napari-${{ env.version }}-${{ runner.os }}-${{ env.arch-suffix }}.${{ env.extension }}
retention-days: 7

- name: Get Release
if: inputs.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')
Expand All @@ -505,18 +506,6 @@ jobs:
asset_name: napari-${{ env.version }}-${{ runner.os }}-${{ env.arch-suffix }}.${{ env.extension }}
asset_content_type: application/octet-stream

- name: Upload Nightly Build Asset
if: ${{ inputs.event_name == 'schedule' }}
uses: WebFreak001/deploy-nightly@v3.1.0
with:
# nightly build release from https://api.github.com/repos/napari/napari/releases
upload_url: https://uploads.github.com/repos/napari/napari/releases/34273071/assets{?name,label}
release_id: 34273071
asset_path: ${{ github.workspace }}/napari-packaging/_work/napari-${{ env.version }}-${{ runner.os }}-${{ env.arch-suffix }}.${{ env.extension }}
asset_name: napari-${{ runner.os }}-${{ env.arch-suffix }}.${{ env.extension }}
asset_content_type: application/octet-stream
max_releases: 1

- name: Test installation (Linux)
if: runner.os == 'Linux'
working-directory: napari-packaging/_work
Expand Down

0 comments on commit 0bb254d

Please sign in to comment.