Skip to content

Commit

Permalink
Update dask version constraint and watch pyproject.toml (#116)
Browse files Browse the repository at this point in the history
* Update dask version constraint

* Rename workflow

* adjust for pyproject.toml

* couple more renames
  • Loading branch information
jaimergp authored Mar 5, 2024
1 parent f88c8f7 commit a4916b4
Show file tree
Hide file tree
Showing 5 changed files with 28 additions and 28 deletions.
15 changes: 15 additions & 0 deletions .github/PYPROJECT_TOML_UPDATED_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
title: "`pyproject.toml` was updated ({{ env.PYPROJECT_TOML_TODAY }})"
assignees: jaimergp
---

The file `pyproject.toml` was modified in `napari/napari`. This might mean the conda-recipe in
`napari/packaging` needs adjusting! Please check!

Calculated diff:

```diff
{{ env.PYPROJECT_TOML_CHANGES }}
```

cc @jaimergp
15 changes: 0 additions & 15 deletions .github/SETUP_CFG_UPDATED_TEMPLATE.md

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -17,40 +17,40 @@ concurrency:
cancel-in-progress: true

jobs:
check_setup_cfg:
check_pyproject_toml_changes:
permissions:
contents: read
issues: write
name: Report setup.cfg changes
name: Report pyproject.toml changes
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
repository: napari/napari
fetch-depth: 0

- name: Did setup.cfg change since yesterday
- name: Did pyproject.toml change since yesterday
run: |
changes="$(git diff $(git log -1 --before=@{last.day} --format=%H) setup.cfg)"
changes="$(git diff $(git log -1 --before=@{last.day} --format=%H) pyproject.toml)"
echo "$changes"
if [[ -n "$changes" ]]; then
echo 'SETUP_CFG_CHANGES<<EOF${{ github.run_id }}' >> $GITHUB_ENV
echo 'PYPROJECT_TOML_CHANGES<<EOF${{ github.run_id }}' >> $GITHUB_ENV
echo "$changes" >> $GITHUB_ENV
echo 'EOF${{ github.run_id }}' >> $GITHUB_ENV
echo "SETUP_CFG_TODAY=$(date -I)" >> $GITHUB_ENV
echo "PYPROJECT_TOML_TODAY=$(date -I)" >> $GITHUB_ENV
fi
- name: Checkout packaging code
if: env.SETUP_CFG_CHANGES && github.event_name == 'schedule'
if: env.PYPROJECT_TOML_CHANGES && github.event_name == 'schedule'
uses: actions/checkout@v4
with:
repository: napari/packaging

- name: Create issue
if: env.SETUP_CFG_CHANGES && github.event_name == 'schedule'
if: env.PYPROJECT_TOML_CHANGES && github.event_name == 'schedule'
uses: JasonEtco/create-an-issue@v2
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
filename: .github/SETUP_CFG_UPDATED_TEMPLATE.md
filename: .github/PYPROJECT_TOML_UPDATED_TEMPLATE.md
update_existing: true
4 changes: 2 additions & 2 deletions conda-recipe/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ This folder is a patched copy of the conda-forge/napari-feedstock `recipe/` dire
- The `outputs` section might be different too to accommodate changes happening during development
(e.g. new dependency was added.)

Use this link to see what happened in `napari/napari:setup.cfg`, compared to last release:
Use this link to see what happened in `napari/napari:pyproject.toml`, compared to last release:

https://github.com/napari/napari/compare/v${VERSION_HERE}...main

and look for `setup.cfg` in the Files tab.
and look for `pyproject.toml` in the Files tab.

The point of having a local copy is to be able to update it while developing the next release,
without needing to publish the changes on conda-forge. On releases, the recipe contents here
Expand Down
4 changes: 2 additions & 2 deletions conda-recipe/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ outputs:
run:
- python >=3.8

# dependencies matched to setup.cfg
# dependencies matched to pyproject.toml
- app-model >=0.2.2,<0.3.0a
- appdirs >=1.4.4
- cachey >=0.2.1
Expand All @@ -43,7 +43,7 @@ outputs:
# in the distributed dependency
# conda-forge doesn't have the dask-array subpackage
# so depend on cytoolz and numpy manually
- dask-core>=2.15.0,!=2.28.0
- dask-core >=2021.10.0
- cytoolz >=0.11.0
- imageio >=2.20,!=2.22.1
- jsonschema >=3.2.0
Expand Down

0 comments on commit a4916b4

Please sign in to comment.