Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constrain dependencies in installer's base env more strictly #187

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Constrain dependencies in installer's base env more strictly #187

merged 5 commits into from
Sep 30, 2024

Conversation

jaimergp
Copy link
Collaborator

@jaimergp jaimergp marked this pull request as ready for review September 30, 2024 11:26
@jaimergp jaimergp mentioned this pull request Sep 30, 2024
Closed
Czaki
Czaki approved these changes Sep 30, 2024
View reviewed changes
Copy link

@Czaki Czaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It means that once conda is updated for new mamba we will need to relax these constraints?

@jaimergp
Copy link
Collaborator Author

Good point. Yes, we will have to rebuild. But let me try without the <2 part, it might work too.

jaimergp
jaimergp commented Sep 30, 2024
View reviewed changes
build_installers.py Outdated Show resolved Hide resolved
@jaimergp
Copy link
Collaborator Author

Yea, a simple, unconstrained mamba works too. Let's merge this and fix rc3.

@jaimergp jaimergp merged commit 03b8872 into main Sep 30, 2024
9 checks passed
@jaimergp jaimergp deleted the fix-base-env-deps branch September 30, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Czaki Czaki Czaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weirdly hard to install a simple pure-python plugin
2 participants
@jaimergp @Czaki