Add package stubs and structure #48
Conversation
goanpeca
force-pushed
the
package-stubs
branch
2 times, most recently
from
5895e95 to
c722fee
Compare
goanpeca
force-pushed
the
package-stubs
branch
from
ee396bc to
5815182
Compare
|
cc @aganders3 to review |
|
the packaging workflow is failing: https://github.com/napari/packaging/actions/runs/3577842461/jobs/6017466411 I assume this is some GitHub action specific issue we have to fix to ship binary to QA testing? |
goanpeca
force-pushed
the
package-stubs
branch
from
1f5997c to
6f5ee6a
Compare
|
Thanks for the comments @aganders3, added fixes :) |
| python_requires = >=3.8 | ||
| include_package_data = True | ||
| package_dir = | ||
| =src |
There was a problem hiding this comment.
is this a typo or intended?
There was a problem hiding this comment.
Intended the foldert structure for the pakcages is
package-name/src/module_name
There was a problem hiding this comment.
I think @potating-potato was referring to the =src. The syntax in setup.cfg here is confusing (bad) but this is not a typo. This gets parsed into a dictionary and that line will have an empty key: https://setuptools.pypa.io/en/latest/userguide/declarative_config.html#specifying-values
There was a problem hiding this comment.
Ahhh got it, yes the syntax is weird. We can eventually migrate to a pyproject toml only and use hatch as the build system https://github.com/pypa/hatch
There was a problem hiding this comment.
thanks for confirming! I indeed never seen this syntax before
goanpeca
requested review from
liu-ziyang and
aganders3
and removed request for
aganders3
|
No objection merging this, I give it a first pass and we can iterate on this quickly |
|
Thanks for the reviews! Merging :) |
Add package structure for CLI and API to simplify review of #34 and #46