-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entity types refactor & remove store/storage modules #137
Conversation
Refactor message of entity validation issues
address: Address | ||
chainId: number | ||
classification: AccountClassification | ||
} | ||
|
||
export type Token = { | ||
uid: string | ||
id: string | ||
address: Address | ||
symbol: string | ||
chainId: number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samteb I feel these types are either redundant with (entity.type.ts) or in the wrong place.
These feel strictly related to how OPA operates, not the engine entities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think you are right. those types seem to be duplicated.
what do you suggest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samteb not sure. I feel these types are crafted for optimizing Rego queries, and we should keep them like that.
Maybe we move these to a specific module called open-policy-agent
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job Doc'
Changelog
id
instead ofuid
for consistencyarmory
to thecaip.util.ts
atpolicy-engine-shared
armory
to theevm.util.ts
atpolicy-engine-shared