Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix - armory crashes on values > bigint #531

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Bugfix - armory crashes on values > bigint #531

merged 2 commits into from
Sep 5, 2024

Conversation

Ptroger
Copy link
Contributor

@Ptroger Ptroger commented Sep 4, 2024

  • Authorization requests are updated with error status
  • It expects only authorization Request errors that got a name and a message property
  • BigInt(valueTooHigh) throws an error without a name
  • Primsa subsequent call to update request with error.name fails, its not thrown and server crashes

Solution:

  • Default values for name and message properties
  • Catch BigInt error to give proper context

@vercel Vercel
Copy link

vercel bot commented Sep 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devtool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 9:14am
manager 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 9:14am

@mattschoch mattschoch merged commit 4ed9fa0 into main Sep 5, 2024
6 checks passed
@mattschoch mattschoch deleted the feature/nar-1924-bug-transaction-request-with-value-too-high-crashes-auth branch September 5, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattschoch mattschoch mattschoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ptroger @mattschoch