Move user journey tests to a package

[Ptroger]

User journey tests are run against the whole monorepo e2e.
They are meant to enforce core functionality works from the end user perspective.

This PR moves these tests from 'armory-sdk' to a different package 'user-journey'.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
devtool	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 23, 2024 10:04am
manager	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Oct 23, 2024 10:04am

[mattschoch]

Seems okay to me!

Personally, I'd maybe just name the package e2e or e2e-test not user-journey, but not a super strong opinion.

[wcalderipe]

Seems okay to me!

Personally, I'd maybe just name the package e2e or e2e-test not user-journey, but not a super strong opinion.

Agree. Here's my 2 cents on the topic.

The convention adopted by NX is <projectName>-e2e. You can see this in Armory Cloud repository, where I intentionally left the test project behind.

However, in this case, we're not testing a single project but the entire stack. For instance, Twenty, a monorepo project I closely follow, uses a slightly different convention: https://github.com/twentyhq/twenty/tree/main/packages/twenty-e2e-testing.

I suggest we adopt something similar, like armory-e2e-testing. It clearly indicates that it's an E2E test for the entire project.

I'm aware that it currently clashes with the apps/armory project name and may be confusing in the short term. However, I believe we'll change that in the future to better represent the three components of the stack: Auth, Policy Engine, and Vault in the apps directory.

@Ptroger you can easily rename a project using NX's rename workspace https://nx.dev/nx-api/workspace/generators/move