delete signMessage decoding #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wcalderipe
reviewed
Oct 23, 2024
| @@ -83,7 +78,7 @@ export type Config = { | |||
| transactionRegistry?: TransactionRegistry | |||
| supportedMethods?: MethodsMapping | |||
| } | |||
| export type DecodeInput = TransactionInput | MessageInput | RawInput | TypedDataInput | |||
| export type DecodeInput = TransactionInput | RawInput | TypedDataInput | |||
There was a problem hiding this comment.
I thought raw and typed data would also be removed. Maybe I misunderstood something.
There was a problem hiding this comment.
I want to remove them. Problem is that changes rego evaluation, because rego uses the result of intent decoding for typed Data. So I'm gonna do it after I merged regal PR. I could have done it for raw here, but I'd rather just limit this PR to signMessage because it's the scope of the bug. Then I'll do the two others in a subsequent one once regal is merged
wcalderipe
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.