Add 2nd set of SVOM notices for ECLAIRs, GRM and MXT #182
Conversation
| "$schema": true, | ||
| "mean_flux": { | ||
| "type": "number", | ||
| "description": "Mean flux of the detection [erg.cm^-2]" |
There was a problem hiding this comment.
Flux units are (erg cm^-2 s^-1), we have energy_flux property defined in our core schema (https://raw.githubusercontent.com/nasa-gcn/gcn-schema/main/gcn/notices/core/spectral/GammaRay.schema.json), might be useful here.
erg cm^-2 is units for fluence.
| }, | ||
| "use_VT_attitude": { | ||
| "type": "boolean", | ||
| "description": "Whether the platform stabilisation process uses the VT instead of the standard star tracker. This leads to an improved localization." |
There was a problem hiding this comment.
Please clearly write about 0, 1 state in the description.
| "$schema": true, | ||
| "slew_status": { | ||
| "enum": ["accepted", "rejected", "not-requested"], | ||
| "description": "Spacecraft slew status" |
There was a problem hiding this comment.
Describe it clearly for the users.
There was a problem hiding this comment.
Looks good.
Main comment: Is it possible to have a separate topic for each instrument (excluding test) - one for eclairs, one for grm, and one for eclgrm (joint-analysis)?
This way, the alert/trigger can be on one Kafka topic for user subscription.
Exception is a test topic that can be an independent topic subscribed by the team.
We have a record number field in the reporter schema (https://raw.githubusercontent.com/nasa-gcn/gcn-schema/main/gcn/notices/core/Reporter.schema.json) for refined Notices."
| "hardness_ratio_error": [0.01], | ||
| "energy_range_soft": [4.0, 20.0], | ||
| "energy_range_hard": [80.0, 120.0], | ||
| "classification": { "short_grb": 26.0, "long_grb": 74.0 }, |
There was a problem hiding this comment.
Interesting!
Suggestion: Either document on the mission page or AdditionalInfo Schema to let the community know which classification scheme you are using.
|
Thanks for your review, I will make the changes. Concerning the topics, actually there will be a separate topic for each instrument. We will always call it by: the instrument, followed by the name of the schema (trigger or refined) and potentially another keyword for more specific notices (slewing/not-slewing, catalog, etc.). Do you find it ok ? |
There was a problem hiding this comment.
Hi @timroland, this branch looks quite done.
Could you please update the description of "slew_status" and classification scheme you are following?
P.S. Sorry I missed your email during Astro-COLIBIRI, wasn't carrying official laptop.
I added the 2nd set of notices for ECLAIRs, GRM and ECLGRM (joint analysis). These are defined in the
refined.schema.jsonI also added the schema and an example for the 1st set of MXT notices in the dedicated folder.
PS: All these notices are refered to level 2 notices in the SVOM nomenclature