Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #392, seg fault - invalid file destination #412

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

dmknutsen
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
Fixes #392 - Adds logic to CF_CFDP_ResetTransaction to check if a transaction has previously been freed prior to resetting the transaction. This PR includes an additional requirement - which is now verified via an updated build verification test to ensure this condition is induced/verified as part of our build release. I also included an additional unit test to maintain 100% coverage.

Testing performed
Steps taken to test the contribution:

  1. Unit/coverage testing
  2. Build verification testing - which includes sending a PDUs with invalid destination filename(s) to ensure doing so is now being handled correctly.

System(s) tested on

  • Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)
Dan Knutsen
NASA Goddard

@dzbaker dzbaker merged commit 046a70a into nasa:main Oct 19, 2023
17 checks passed
@dmknutsen dmknutsen added the bug label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seg Fault when invalid destination filename is invalid
3 participants