Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #430, correct type mismatches #431

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

jphickey
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
Correction for various type mismatches across CF.
Notably, many iterators do not use the CFE_Status_t return type, it should be a custom enum.

Fixes #430

Testing performed
Build and run all tests
Run BP/DTN sanity check (uses CF to transfer file)

Expected behavior changes
Builds and runs on strict type-checking platforms

System(s) tested on
Debian with RTEMS 4.11 toolchain

Additional context
This may have been recently complicated as some return codes were changed to CFE_Status_t that should have remained as an integer (e.g. cases where it was a count or not one of the CFE error codes)

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Correction for various type mismatches across CF.
Notably, many iterators do not use the CFE_Status_t return
type, it should be a custom enum.
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL-coding-standard found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@jphickey jphickey added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jan 10, 2024
@dzbaker dzbaker added CCB:Approved and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jan 11, 2024
@dzbaker dzbaker merged commit 0a9d4a1 into nasa:main Jan 11, 2024
17 checks passed
@jphickey jphickey deleted the fix-430-type-mismatch branch January 16, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various type mismatches in CF
2 participants