Fix #444, Adds JSC 2.1 Static Analysis comments and exposes CF_strnlen #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chillfig
added
bug
CCB:Ready
chillfig
force-pushed
the
SA_jsc2_1
branch
2 times, most recently
from
ac96459
to
b532de9
Compare
chillfig
changed the title
chillfig
commented
Jun 20, 2024
fsw/src/cf_utils.c
Outdated
| snprintf(linebuf, sizeof(linebuf), "DST: %s\n", history->fnames.dst_filename); | ||
| break; | ||
| } | ||
|
|
||
| /* SAD: Using strlen since linebuf is guaranteed to be null-terminated by snprintf */ | ||
| len = strlen(linebuf); |
There was a problem hiding this comment.
CCB 06/13/2024: Consider using memchr. Check if return null. Can create App_strnlen() locally static inline if deemed applicable.
There was a problem hiding this comment.
app-scope CF_strlen using memchar has been implemented where strlen was previously used
2 tasks
This commit addresses issues flagged during static analysis by: - Adding JSC 2.1 disposition comments. - Replacing strlen with OS_strnlen.
dzbaker
added
CCB:Approved
and removed
CCB:Ready
|
CCB 27 June 2024: Will re-run workflows once osal#1465 is merged in to verify they pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Testing performed
None, only comments are added.
Expected behavior changes
N/A
System(s) tested on
N/A
Additional context
Depends on nasa/osal#1465
Third party code
N/A
Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, Vantage Systems