DAS-2255: rename service consistently. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a couple of different service names sprinkled throughout. This just goes with how the other services have been named by using the full repository name with hyphens.
flamingbear
requested review from
owenlittlejohns,
lyonthefrog and
vutrannasa
|
There's some future work in the offing that I'll probably be spearheading in the next PI to standardise Harmony services as they are presenting in the UMM-S records, and therefore in EDSC. But that is a separate layer of the cake, being in CMR-land. (Well, it's on my stack of things that need to be done, at least) |
vutrannasa
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR just just aligns the service names with how the other services are
named by using the full repository name with hyphens.
This was uncovered because the GitHub action builds based on the repository
name. I could have changed it to match the smap-l2-gridder but decided to
follow the lead of other existing services.
Jira Issue ID
DAS-2255
Local Test Steps
verify that you don't have an smap docker images.
If you do, delete it:
Pull this branch and build the image. Verify it has the correct name
PR Acceptance Checklist
CHANGELOG.mdupdated to include high level summary of PR changes.docker/service_version.txtupdated if publishing a release.